-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem Attributes #130
base: main
Are you sure you want to change the base?
Problem Attributes #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks good.
difficulty: string().allow(''), | ||
dateCreated: date().iso(), | ||
lastModified: date().iso(), | ||
footer: string().allow(''), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this footer for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the code footer. I think the frontend was modified to sometime use it so it won't run without this in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I submitted some comments addressing your concerns.
difficulty: string().allow(''), | ||
dateCreated: date().iso(), | ||
lastModified: date().iso(), | ||
footer: string().allow(''), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the code footer. I think the frontend was modified to sometime use it so it won't run without this in.
Description
This is the backend pull request required to allow problem attributes. Please look at this pull request for more information.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):