Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem Attributes #130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Problem Attributes #130

wants to merge 1 commit into from

Conversation

blakerand
Copy link
Contributor

Description

This is the backend pull request required to allow problem attributes. Please look at this pull request for more information.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Copy link
Contributor

@kapooramanpreet kapooramanpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good.

src/api/controllers/problem.controller.ts Show resolved Hide resolved
difficulty: string().allow(''),
dateCreated: date().iso(),
lastModified: date().iso(),
footer: string().allow(''),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this footer for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the code footer. I think the frontend was modified to sometime use it so it won't run without this in.

Copy link
Contributor Author

@blakerand blakerand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted some comments addressing your concerns.

src/api/controllers/problem.controller.ts Show resolved Hide resolved
difficulty: string().allow(''),
dateCreated: date().iso(),
lastModified: date().iso(),
footer: string().allow(''),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the code footer. I think the frontend was modified to sometime use it so it won't run without this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants