Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] swagger바탕으로 api작성과 네비게이션바 동작하게 변경 그리고 로그인 상태 저장 로그인 상태에 따라 네비게이션 따로 보여주기 #137

Merged
merged 53 commits into from
Sep 10, 2024

Conversation

seroak
Copy link
Contributor

@seroak seroak commented Sep 5, 2024

#️⃣ 연관된 이슈

📝 작업 내용

  • swagger바탕으로 api주소 변경
  • msw로 회원가입과 로그인 동작하게 변경 msw로 jwt 토근 보내고 저장되는 거 확인
  • 로그인 성공하면 로그인 상태 정보 저장과 쿠키 저장
  • 로그인 상태에 따라 네비게이션바 다르게 보여주기

msw로 새로고침 할 때 백엔드로 로그인 상태 정보를 불러오는 기능을 구현하려고 했는데 새로고침시 get요청을 보낸 후에 msw가 실행되는 버그 있는 것으로 확인돼서 새로고침시 로그인 상태정보를 불러오는 것을 확인하지 못함 백엔드를 연결해서 확인해야 합니다

관련 이슈 블로그와 깃허브 페이지
https://mswjs.io/docs/integrations/browser#conditionally-enable-mocking
blacktokkies/toquiz-client#68

@seroak seroak requested review from ujkkk and SongGwanSeok September 5, 2024 05:02
@seroak seroak self-assigned this Sep 5, 2024
src/App.tsx Show resolved Hide resolved
src/mocks/handlers.ts Outdated Show resolved Hide resolved
Copy link
Member

@SongGwanSeok SongGwanSeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ujkkk ujkkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰남겼습니다!

src/mocks/handlers.ts Outdated Show resolved Hide resolved
src/pages/Visualization/Visualization.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@ujkkk ujkkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seroak seroak merged commit b189395 into develop Sep 10, 2024
@seroak seroak deleted the feat/issue136 branch September 10, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]swagger 바탕으로 로그인 api와 회원가입 api 연결과 msw로 회원가입 로그인 구현
3 participants