Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): fixed publishing notification #23

Merged
merged 4 commits into from
Aug 22, 2024
Merged

fix(publish): fixed publishing notification #23

merged 4 commits into from
Aug 22, 2024

Conversation

e11sy
Copy link
Contributor

@e11sy e11sy commented Aug 22, 2024

Problem

image
Notification works for root package that is not even published (it is private)

Expected behaviour

Expected to receive notifications about packages, those versions were bumped (packages, that was actually published)

Solution

Since we use custom publish:ci script for publishing, we should notify also in this script (because workflow has no info about packages)
Now in publish, we check if package was published, and notify about ones that actually publised

Changes

  • Removed notify step from publish workflow
  • Added publishing part to publish:ci script

Additional

  • Linked get repository in every package.json
  • Bump versions to test notifications

@e11sy e11sy merged commit 55a8924 into main Aug 22, 2024
3 checks passed
@e11sy e11sy deleted the fix-notification branch August 22, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants