Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor of edgex docs #1212

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

jpwhitemn
Copy link
Member

fix:#1151

use of latest mkdocs with mike versioning

addition of home 'tile' like display

removed javascript for versioning

redo of #1171 resolving all merge conflicts

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)

use of latest mkdocs with mike versioning

addition of home 'tile' like display

removed javascript for versioning

Signed-off-by: jpwhitemn <[email protected]>
ernestojeda
ernestojeda previously approved these changes Sep 6, 2023
Copy link
Contributor

@ernestojeda ernestojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just had a question I put inline

mkdocs.yml Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
renamed version to edgeversion in macro template per review suggestion

Signed-off-by: jpwhitemn <[email protected]>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 45032f4 into edgexfoundry:main Sep 8, 2023
edgex-jenkins added a commit that referenced this pull request Sep 8, 2023
@jpwhitemn jpwhitemn deleted the refactor-docs branch September 13, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants