Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kata-msft: support images with VOLUME directives #996

Merged
merged 9 commits into from
Nov 28, 2024

Conversation

miampf
Copy link
Contributor

@miampf miampf commented Nov 12, 2024

Remove the volumeMounts fix since kata-containers/kata-containers#10136 was merged

@miampf miampf added no changelog PRs not listed in the release notes do not merge This shouldn't be merged at this point labels Nov 12, 2024
@miampf miampf force-pushed the miampf/verify-volume-fix branch 5 times, most recently from f065fb6 to ec93aa6 Compare November 21, 2024 10:40
@miampf miampf removed the do not merge This shouldn't be merged at this point label Nov 21, 2024
@miampf miampf marked this pull request as ready for review November 21, 2024 16:46
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@miampf miampf force-pushed the miampf/verify-volume-fix branch 2 times, most recently from 3a729d6 to 982afd1 Compare November 26, 2024 10:18
@burgerdev
Copy link
Contributor

https://github.com/edgelesssys/contrast/actions/runs/12028677575/job/33539834180?pr=996#step:11:273 is a Nydus flake, so feel free to merge after fixing the commit structure (or squash).

@burgerdev burgerdev changed the title e2e: remove volumeMounts fix kata-msft: support images with VOLUME directives Nov 26, 2024
@burgerdev burgerdev added bug fix Fixing a user facing bug and removed no changelog PRs not listed in the release notes labels Nov 26, 2024
@miampf miampf merged commit f5a372c into main Nov 28, 2024
19 of 20 checks passed
@miampf miampf deleted the miampf/verify-volume-fix branch November 28, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixing a user facing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants