-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kata-msft: support images with VOLUME directives #996
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miampf
added
no changelog
PRs not listed in the release notes
do not merge
This shouldn't be merged at this point
labels
Nov 12, 2024
miampf
force-pushed
the
miampf/verify-volume-fix
branch
5 times, most recently
from
November 21, 2024 10:40
f065fb6
to
ec93aa6
Compare
miampf
force-pushed
the
miampf/verify-volume-fix
branch
from
November 21, 2024 13:41
ec93aa6
to
d01d663
Compare
burgerdev
reviewed
Nov 21, 2024
.../by-name/microsoft/genpolicy/0007-genpolicy-support-for-VOLUME-definition-in-container.patch
Outdated
Show resolved
Hide resolved
burgerdev
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
packages/by-name/microsoft/genpolicy/0001-genpolicy-add-rules-and-types-for-volumeDevices.patch
Outdated
Show resolved
Hide resolved
packages/by-name/microsoft/genpolicy/genpolicy_msft_settings_coordinator.patch
Show resolved
Hide resolved
packages/by-name/microsoft/genpolicy/genpolicy_msft_settings_dev.patch
Outdated
Show resolved
Hide resolved
.../by-name/microsoft/genpolicy/0007-genpolicy-support-for-VOLUME-definition-in-container.patch
Outdated
Show resolved
Hide resolved
miampf
force-pushed
the
miampf/verify-volume-fix
branch
2 times, most recently
from
November 26, 2024 10:18
3a729d6
to
982afd1
Compare
miampf
force-pushed
the
miampf/verify-volume-fix
branch
from
November 26, 2024 10:30
4c811c4
to
ba3cb32
Compare
burgerdev
approved these changes
Nov 26, 2024
https://github.com/edgelesssys/contrast/actions/runs/12028677575/job/33539834180?pr=996#step:11:273 is a Nydus flake, so feel free to merge after fixing the commit structure (or squash). |
burgerdev
changed the title
e2e: remove
kata-msft: support images with VOLUME directives
Nov 26, 2024
volumeMounts
fix
burgerdev
added
bug fix
Fixing a user facing bug
and removed
no changelog
PRs not listed in the release notes
labels
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
volumeMounts
fix since kata-containers/kata-containers#10136 was merged