Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "admin" role issue with different servers #1423

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Fix "admin" role issue with different servers #1423

merged 6 commits into from
Dec 6, 2024

Conversation

fantix
Copy link
Member

@fantix fantix commented Dec 5, 2024

  • Check 6.0 alpha versions correctly (early 6.0 nightlies are no longer supported)
  • Still bootstrap 5.x and earlier instances with "edgedb" as the default default_user

Refs #1412, #1413

@fantix fantix requested review from msullivan and mmastrac December 5, 2024 17:13
msullivan
msullivan approved these changes Dec 5, 2024
View reviewed changes
src/portable/create.rs Outdated Show resolved Hide resolved
mmastrac
mmastrac reviewed Dec 5, 2024
View reviewed changes
src/portable/project.rs Outdated Show resolved Hide resolved
mmastrac
mmastrac approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small request

@fantix fantix merged commit defcea3 into master Dec 6, 2024
17 checks passed
@fantix fantix deleted the fix-admin branch December 6, 2024 15:15
msullivan pushed a commit that referenced this pull request Dec 17, 2024
@fantix @msullivan
Fix "admin" role issue with different servers (#1423)
8b7a5dd
msullivan added a commit that referenced this pull request Dec 17, 2024
@msullivan
edgedb-cli 6.0.3
77d7e9a 
Fixes
=====

* Rename config apply_access_policies_sql to apply_access_policies_pg.
  (by @dnwpark in 8a5e750 for #1426)

* Fix "admin" role issue with different servers
  (by @fantix in 8b7a5dd for #1423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

@msullivan msullivan msullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fantix @msullivan @mmastrac