Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): Added survey group ID input parameter to list_surveys #1242

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Dec 27, 2024

Summary

Test Plan

  • Add a subtest for the gsid input and output parameter.

Checklist

  • My pull request has a descriptive title.
  • I have read the CONTRIBUTING guide.
  • I have added tests that prove my fix is effective or that my feature works.
  • If appropriate, I have added necessary documentation.
  • For user-facing changes, refactorings, performance improvements or documentation updates, I have added a changelog entry using Changie.

For both the title of the PR and the changelog entry, prefer simple past tense or constructions with "now". For example:

  • Added Client.invite_participants()
  • Client.user_activation_settings() now accepts a user_activation_settings keyword argument

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e33a886) to head (eb8b982).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1242   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          495       495           
  Branches        13        13           
=========================================
  Hits           495       495           
Flag Coverage Δ
integration 91.51% <100.00%> (ø)
unit 93.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/list-surveys-gsid branch from d4d9b1e to 765a896 Compare December 27, 2024 01:57
@edgarrmondragon edgarrmondragon added the Release Package version bump label Dec 27, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/list-surveys-gsid branch from 765a896 to dc18533 Compare December 27, 2024 02:03
@edgarrmondragon edgarrmondragon marked this pull request as draft December 27, 2024 02:04
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/list-surveys-gsid branch from dc18533 to 4ba5f50 Compare December 27, 2024 02:24
@edgarrmondragon edgarrmondragon self-assigned this Dec 27, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/list-surveys-gsid branch from 4ba5f50 to eb8b982 Compare December 27, 2024 02:29
@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 27, 2024 03:10
@edgarrmondragon edgarrmondragon merged commit 9fe8ac5 into main Dec 27, 2024
56 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/feat/list-surveys-gsid branch December 27, 2024 04:00
@edgarrmondragon edgarrmondragon added the RPC Issues related to the RPC client implementation label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Package version bump RPC Issues related to the RPC client implementation
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants