Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix gha-update workflow #1191

Merged
merged 1 commit into from
Oct 1, 2024
Merged

ci: Fix gha-update workflow #1191

merged 1 commit into from
Oct 1, 2024

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Oct 1, 2024 •
edited
Loading

Summary

Test Plan

Checklist

  • My pull request has a descriptive title.
  • I have read the CONTRIBUTING guide.
  • I have added tests that prove my fix is effective or that my feature works.
  • If appropriate, I have added necessary documentation.
  • For user-facing changes, refactorings, performance improvements or documentation updates, I have added a changelog entry using Changie.

For both the title of the PR and the changelog entry, prefer simple past tense or constructions with "now". For example:

  • Added Client.invite_participants()
  • Client.user_activation_settings() now accepts a user_activation_settings keyword argument

📚 Documentation preview 📚: https://citric--1191.org.readthedocs.build/en/1191/

@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 1, 2024 01:03
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) October 1, 2024 01:03
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@edgarrmondragon edgarrmondragon merged commit ae91479 into main Oct 1, 2024
11 checks passed
@edgarrmondragon edgarrmondragon deleted the fix-gha-update branch October 1, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeurdestenebres coeurdestenebres coeurdestenebres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgarrmondragon @coeurdestenebres