update to use .index_max() #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an Armadillo 14.2.0 change that creates a fair amount of compilation noise for mlpack right now.
eddelbuettel
requested changes
Nov 22, 2024
There was a problem hiding this comment.
This retains a warning. The point is to get rid of warnings as much as we can:
/home/edd/git/mlpack/src/mlpack/methods/perceptron/perceptron_impl.hpp:228:32: warning: unused variable ‘maxIndexCol’ [-Wunused-variable]
228 | arma::uword maxIndexRow = 0, maxIndexCol = 0;
| ^~~~~~~~~~~
|
@eddelbuettel I'm bandwidth constrained, so feel free to edit this PR, or merge and adapt further as you see fit. |
GitHub usually indicates when I can, and this feature is on by default. I do not see it here. So in short: I can't. |
eddelbuettel
force-pushed
the
feature/arma_14.2.0
branch
from
6efd91f to
db6b014
Compare
|
The commit 9ed1f4b is now part of the PR 3835 so this is take care of. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to PR mlpack#3835