Skip to content

Commit

Permalink
final preparation for cran submission
Browse files Browse the repository at this point in the history
  • Loading branch information
comeetie committed Mar 18, 2022
1 parent 4af2175 commit 5567110
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 24 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Package: greed
Type: Package
Title: Clustering and Model Selection with the Integrated Classification Likelihood
Version: 0.6.0
Date: 2022-01-15
Date: 2022-03-18
Authors@R:
c(person(given = "Etienne",
family = "Côme",
Expand Down
49 changes: 26 additions & 23 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,51 +1,57 @@
Dear cran members.

This submission correspond to version 0.6 of package greed. The check results obtained are similar to those of the previous version.
This submission correspond to version 0.6 of package greed. The check results obtained are similar to those of the previous version. I added to my tests a check on fedora-clang-rdevel since the current cran check result page for greed give a warning with it. The results obtained with R-hub and this image do not raise a warning anymore. The main changes are listed in the NEWS.md file and the check result details follows.

## Test environments

* ubuntu 20.04 (on github-action), R 4.1.3
* ubuntu 20.04 (on github-action), R-devel
* windows (on github-action), R 4.1.3
* macOS-11 (on github-action), R 4.1.3
* windows server 2019 (on github-action), R 4.1.3
* macOS-latest (on github-action), R 4.1.3
* solaris 10 (on rhub), R 4.1.3
* fedora-clang (on rhub), R-devel

## R CMD check results

I still have one note on installed package size that comes from my usage of RcppArmadillo and on UTF-8 usage on SOLARIS.

### solaris-release

── R CMD check results ──────────────────────────────────────── greed 0.5.1 ────
Duration: 6m 58.3s
### fedora-clang-devel
── R CMD check results ──────────────────────────────────────── greed 0.6 ────

❯ checking installed package size ... NOTE
installed size is 24.4Mb
sub-directories of 1Mb or more:
libs 22.1Mb
❯ checking data for non-ASCII characters ... NOTE
Note: found 6693 marked UTF-8 strings
Note: found 989 marked UTF-8 strings

0 errors ✔ | 0 warnings ✔ | 2 note ✖

### solaris-release
── R CMD check results ──────────────────────────────────────── greed 0.6 ────

❯ checking data for non-ASCII characters ... NOTE
Note: found 989 marked UTF-8 strings

0 errors ✔ | 0 warnings ✔ | 1 note ✖

### macOS-release

── R CMD check results ──────────────────────────────────────── greed 0.5.1 ────
Duration: 7m 9.9s
── R CMD check results ──────────────────────────────────────── greed 0.6.0 ────

0 errors ✔ | 0 warnings ✔ | 0 notes ✔

### windows-release
── R CMD check results ──────────────────────────────────────── greed 0.5.1 ────
Duration: 13m 24.6s

❯ checking installed package size ... NOTE
installed size is 5.5Mb
installed size is 7.2Mb
sub-directories of 1Mb or more:
libs 4.6Mb

libs 4.6Mb
0 errors ✔ | 0 warnings ✔ | 1 note ✖

### Ubuntu 20.04-release

── R CMD check results ──────────────────────────────────────── greed 0.6.0 ────
Duration: 6m 23.9s

❯ checking installed package size ... NOTE
installed size is 45.5Mb
Expand All @@ -55,15 +61,12 @@ Duration: 6m 23.9s
0 errors ✔ | 0 warnings ✔ | 1 note ✖

### Ubuntu 20.04-devel


── R CMD check results ──────────────────────────────────────── greed 0.5.1 ────
Duration: 6m 58.3s
── R CMD check results ──────────────────────────────────────── greed 0.6 ────

❯ checking installed package size ... NOTE
installed size is 43.5Mb
installed size is 45.5Mb
sub-directories of 1Mb or more:
libs 42.5Mb
libs 42.8Mb

0 errors ✔ | 0 warnings ✔ | 1 note ✖

Expand Down

0 comments on commit 5567110

Please sign in to comment.