Add additional ssh options #24
Conversation
8acker
force-pushed
the
scp-additional-ssh-options
branch
from
9a19fd9 to
45a3ab5
Compare
8acker
force-pushed
the
scp-additional-ssh-options
branch
from
45a3ab5 to
25846f6
Compare
|
Hi, together, could someone review and merge this please? |
|
@ecto Would be nice to merge this |
| path: '~' | ||
| path: '~', | ||
| ssh_options: { | ||
| StrictHostKeyChecking: "no", |
There was a problem hiding this comment.
these examples use a different indentation from the rest of the file
| result += "-o " + key + '=' + ssh_options[key] + ' ' | ||
| }) | ||
| return result.trim(); | ||
| } |
There was a problem hiding this comment.
please match the indentation to the rest of the file
There was a problem hiding this comment.
there is inconsistent use of semicolons here, please use them everywhere
| function buildSshOptions(options) { | ||
| result = ''; | ||
| var ssh_options = options.ssh_options || {} | ||
| ssh_options['ControlMaster'] = 'no' |
There was a problem hiding this comment.
this should be a default but overridable
| @@ -32,12 +41,14 @@ scp.send = function (options, cb) { | |||
| * Grab a file from a remote host | |||
| */ | |||
| scp.get = function (options, cb) { | |||
| var ssh_options = ["ControlMaster=no"]; //callback is not fired if ssh sessions are shared | |||
There was a problem hiding this comment.
this is redundant given similar code in buildSshOptions, but also doesn't work because buildSshOptions expects ssh_options to be an object
| @@ -32,12 +41,14 @@ scp.send = function (options, cb) { | |||
| * Grab a file from a remote host | |||
| */ | |||
| scp.get = function (options, cb) { | |||
| var ssh_options = ["ControlMaster=no"]; //callback is not fired if ssh sessions are shared | |||
| ssh_options = options.ssh ? ssh_options.concat(options.ssh) : ssh_options; | |||
There was a problem hiding this comment.
can you make ssh_options camelCase please? nothing else in this project is snake_case
|
Thanks for the review! @tb0uchnafa Do you have time to work on those? If you want I can do the fixes later today and push them to your repo |
Hi together, i added the possibility to add additional ssh options hope this fits
Cheers