fix: boundingRect.x of text is incorrect when overflow: 'truncate'.
#1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lose apache/echarts#18306 . And #1091 located the problematic code successfully but the fix was not entirely correct.
plainheart
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Current behavior: Hovering mouse over an axis label should have a click target that is aligned with the axis label text. Click target is where mouse pointer is hovering in the screenshot.
This PR fix it.
Original bug issue: apache/echarts#18306 .
And #1091 located the problematic code successfully (thanks @linghaoSu , it's helpful). But the fix was not entirely correct.
Memo info: This code used to be modified in commits bd2642e and bd2642e , where the
boundingRect.widthwas modified fromstyle.widthtoinnerWithand thenouterWith, but theboundingRect.xwas not modified correspondingly.Reproduce & Test case
zrender/test/text-overflow.html
Set in the config panel:
overflow: 'truncate'align: 'center'rich"abcde", check whether the mouse pointer style changes in correct place.