Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: still publish build folder to npm as echarts needs it #1089

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

plainheart
Copy link
Collaborator

#1085 excluded the whole build folder from npm package, which is imported by echarts and causes the echarts package to fail to publish. So this PR is to add this folder back.

[1] https://github.com/apache/echarts/actions/runs/9971316886/job/27552144963#step:4:59
[2] https://github.com/apache/echarts/blob/master/build/pre-publish.js#L42

@Ovilia Ovilia merged commit 247e119 into master Jul 17, 2024
3 checks passed
@Ovilia Ovilia deleted the fix-npmignore branch July 17, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants