Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new handle to object stores that support S3 API #107

Draft
wants to merge 97 commits into
base: develop
Choose a base branch
from
Draft

Adds new handle to object stores that support S3 API #107

wants to merge 97 commits into from

Conversation

mcakircali
Copy link
Contributor

Adds S3 support via AWS SDK C++

mcakircali and others added 30 commits January 31, 2024 17:07
@mcakircali
feat(S3): initial commit for AWS S3 support
c70f2ce
@mcakircali
refactor(S3): removed UPtr and SPtr
c182574
@mcakircali
feat(S3)!: adds Config, Session, Client, Context
e92e14e
@mcakircali
feat(S3): add create,delete,list for bucket and put,list object
5fbf932
@mcakircali
feat(S3): adds delete,list object
4aaec56
@mcakircali
fix(S3): throw on unkown S3 client type
eda4bfd
@mcakircali
feat(S3): adds credentials to S3Config
3fb4e4d
@mcakircali
refactor(S3): throw instead of return boolean
408d9c2
@mcakircali
chore(S3): remove advanced attribute from AWS_S3 cmake option
028a4ee
@mcakircali
style(S3): fix todo style comment
7423b5c
@mcakircali
refactor(S3): namedspace -> unnamed namespace
c3e93a2
@mcakircali
refactor(S3): cleanup S3Session
1aab48f
@mcakircali
fix(S3): add missing pragma once
d775bff
@mcakircali
refactor(S3): cleanup S3Handle
620fd18
@mcakircali
refactor(S3): more cleanup for S3Handle, S3Name
de556ff
@mcakircali
fix(S3): aws error parsing
ed4ed4b
@mcakircali
feat(S3): rework credentials
7eaa9be
@simondsmart
Add some URI infrastructure, and tweak some tests
545f8c6
@mcakircali
refactor(S3): rework S3Config
e8bcf92
@mcakircali
feat(S3): start S3Name and S3URIManager
c84f046
@mcakircali
Merge remote-tracking branch 'refs/remotes/origin/feature/backend-s3'…
a7bdb15 
… into feature/backend-s3
@mcakircali
fix(S3): authority must be true
563679e
@mcakircali
feat(Endpoint): construct from a URI
2003a5c
@mcakircali
fix(S3): client missing error msg
ff342d1
@mcakircali
feat(S3): S3Name: parse bucket/object, exists, size
4fbcea1
@mcakircali
feat(S3): add bucket/object exists, object size
929c0f2
@mcakircali
refactor(S3): session cleanup
611742a
@mcakircali
feat(S3): adds open and size to S3Handle
894bbae
@mcakircali
fix(S3): adapt s3handle test
6a95ecb
@mcakircali
refactor(S3): cleanup and copyright fix
140d75d
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.74%. Comparing base (2cf7ebe) to head (50e3a25).

Files with missing lines Patch % Lines
src/eckit/net/Endpoint.cc 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #107      +/-   ##
===========================================
- Coverage    63.74%   63.74%   -0.01%     
===========================================
  Files         1066     1066              
  Lines        55360    55363       +3     
  Branches      4086     4086              
===========================================
  Hits         35289    35289              
- Misses       20071    20074       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcakircali mcakircali changed the title Feature/backend s3 Adds new handle to object stores that support S3 API Mar 5, 2024
@github-actions GitHub Actions
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12382121355.

@github-actions GitHub Actions
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12382788921.

@github-actions GitHub Actions
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12397515260.

1 similar comment
@github-actions GitHub Actions
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12397515260.

@github-actions GitHub Actions
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12421965256.

@github-actions GitHub Actions
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12465001469.

@github-actions GitHub Actions
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12481699487.

@github-actions GitHub Actions
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/12553367445.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simondsmart simondsmart Awaiting requested review from simondsmart

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcakircali @FussyDuck @codecov-commenter @simondsmart @nicolau-manubens