Refactor CI using ecmwf-actions #66
Conversation
.github/workflows/build.yml
Outdated
| include: | ||
|
|
||
| - name: linux gnu-10 | ||
| os: ubuntu-20.04 |
There was a problem hiding this comment.
Any particular reason for using the relatively old runner image here? 20.04 is EOL in a couple of months and I expect GH might make these runners unavailable soon after.
.github/workflows/build.yml
Outdated
| caching: true | ||
|
|
||
| - name: linux nvhpc-23.5 | ||
| os: ubuntu-20.04 |
There was a problem hiding this comment.
Same (also for intel below)
| # Trigger the workflow on all pushes, except on tag creation | ||
| push: | ||
| branches: | ||
| - '**' |
There was a problem hiding this comment.
Can we restrict the runs on push to the main branch only, please? Pull requests are already enabled below, as well as manual workflow dispatches for early testing.
There was a problem hiding this comment.
I disagree with that. Having the tests run by themselves for any commit when experimenting on a branch is very useful and should not be deactivated. It's better to be aware of a problem as soon as possible than at the final step when opening a pull request.
And having to run the tests by hand seems to defeat the purpose of continuous integration.
There was a problem hiding this comment.
I guess this is a matter of taste and resource management. I often push non-final things to branches, where I know full well that they won't pass testing and so I would not want to waste resources on default testing for that. For near-completion integration testing, I find Draft Pull Requests useful, which do test on every individual push. But hey, if your workflow varies and you'd like this, we can enable this for the public GH-hosted runners.
However, on the other PR for the ECMWF HPC testing, I would like to keep this restricted, as this is a shared and somewhat limited resource that is used across multiple repositories and by multiple developers. Spamming the GPU-debug-queue with non-final branch pushes can impact others quite easily here.
There was a problem hiding this comment.
Yes I would like to keep it for the public GH-hosted runners please.
And I understand you don't want to overload your GPU-queue.
awnawab
force-pushed
the
naan-ecmwf-actions
branch
from
7e8486c to
201d998
Compare
awnawab
force-pushed
the
naan-ecmwf-actions
branch
from
201d998 to
8d904aa
Compare
awnawab
force-pushed
the
naan-ecmwf-actions
branch
from
8d904aa to
b7ceab9
Compare
This PR brings the FIELD_API CI in line with other software packages by using ecmwf-actions. Coverage is also extended to include: