Revise project structure #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an effort to structure the codebase better, this commit moves the modules that are responsible for the layout to a subfolder `layout/` and the modules that implement the rendering to a subfolder `render/`.
To eliminate circular dependencies, `Frame` and related types are moved to a dedicated module `frame`.
To eliminate circular dependencies, `MakerCtx` is moved to a dedicated module `maker-ctx`.
To eliminate circular dependencies, `FontStore` and `ImageStore` are moved into the `font-loader` and `image-loader` modules, respectively.
In order to distinguish the public API from internal code, this commit moves all modules that contribute to the public API to a dedicated folder.
This commit improves the typing of the `namedColors` object, whose values are tuples of exactly three numbers.
Suggested by VSCode.
Node.js supports importing built-in modules using `node:` URLs. These imports are also supported by Deno and Bun. This commit updates all imports of Node.js built-in modules to use `node:` URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.