🐛 Prevent breaking text before the first row #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `layoutText` function returns a frame and optionally a remainder containing the rows that did not fit into the available space. If even the first row did not fit, this function would return an empty frame and a remainder containing all the content. This would result in rendering an empty frame. This empty frame is not only redundant, it could even contain a misleading anchor. This commit prevents this situation by preventing a break before the first row of text.
ralfstx
force-pushed
the
no-empty-frame
branch
from
0bcf089
to
122ddfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
layoutTextfunction returns a frame and optionally a remainder containing the rows that did not fit into the available space.If even the first row did not fit, this function would return an empty frame and a remainder containing all the content. This would result in rendering an empty frame. This empty frame is not only redundant, it could even contain a misleading anchor.
This commit prevents this situation by preventing a break before the first row of text.