🐛 Fix duplicated row after line break #60
Merged
+62
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the layout of a rows block, when there was not enough space left on a page for another row, the layout of that row would return an empty frame with a remainder that contained the entire row. When even this empty frame (`height: 0`) did not fit onto the old page because its margin would exceed the max height, a page break would have been inserted _before_ that frame. However, the remainder would still be prepended to the next page, resulting in a duplication of the row. This commit fixes this bug by only prepending the remainder to the next page when the frame that accompanied this remainder is actually included in the old page, i.e. the page break is inserted _after_ that frame.
ralfstx
force-pushed
the
mr-fix-double-row
branch
from
39f6adc
to
1b62f22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the layout of a rows block, when there was not enough space left on a page for another row, the layout of that row would return an empty frame with a remainder that contained the entire row. When even this empty frame (
height: 0) did not fit onto the old page because its margin would exceed the max height, a page break would have been inserted before that frame. However, the remainder would still be prepended to the next page, resulting in a duplication of the row.This commit fixes this bug by only prepending the remainder to the next page when the frame that accompanied this remainder is actually included in the old page, i.e. the page break is inserted after that frame.