Upgrade V8 to v10.3.174.14

.github/workflows/build_and_release.yml

@@ -13,9 +13,9 @@ jobs:
 
     - name: Download monolithic libraries and extract to v8.out
       run: |
-        curl -k -O http://download.eclipsesource.com/j2v8/v8/libv8_9.3.345.11_monolith.zip
+        curl -k -O http://download.eclipsesource.com/j2v8/v8/libv8_10.3.174.14_monolith.zip
         mkdir -p v8.out
-        unzip libv8_9.3.345.11_monolith.zip -d v8.out
+        unzip libv8_10.3.174.14_monolith.zip -d v8.out
 
     - name: Start J2V8 build
       run: |

.github/workflows/build_and_test.yml

@@ -13,9 +13,9 @@ jobs:
 
     - name: Download monolithic libraries and extract to v8.out
       run: |
-        curl -k -O http://download.eclipsesource.com/j2v8/v8/libv8_9.3.345.11_monolith.zip
+        curl -k -O http://download.eclipsesource.com/j2v8/v8/libv8_10.3.174.14_monolith.zip
         mkdir -p v8.out
-        unzip libv8_9.3.345.11_monolith.zip -d v8.out
+        unzip libv8_10.3.174.14_monolith.zip -d v8.out
 
     - name: Start J2V8 build
       run: python2 build.py -t linux -a x64 --docker j2v8cmake j2v8jni j2v8cpp j2v8optimize j2v8java j2v8test
@@ -24,7 +24,7 @@ jobs:
       uses: actions/[email protected]
       with:
         name: j2v8-linux-x86_64
-        path: build.out/j2v8_linux_x86_64-6.2.1.jar
+        path: build.out/j2v8_linux_x86_64-6.2.2.jar
 
   build_j2v8_android:
     name: Build J2V8 for Android
@@ -36,9 +36,9 @@ jobs:
 
     - name: Download monolithic libraries and extract to v8.out
       run: |
-        curl -k -O http://download.eclipsesource.com/j2v8/v8/libv8_9.3.345.11_monolith.zip
+        curl -k -O http://download.eclipsesource.com/j2v8/v8/libv8_10.3.174.14_monolith.zip
         mkdir -p v8.out
-        unzip libv8_9.3.345.11_monolith.zip -d v8.out
+        unzip libv8_10.3.174.14_monolith.zip -d v8.out
 
     - name: Start J2V8 build
       run: |

CMakeLists.txt

@@ -166,8 +166,8 @@ source_group("" FILES ${src_files})
 # BUILD SETTINGS & COMPILATION
 #-----------------------------------------------------------------------
 
-# tell gcc/clang to use the c++14 standard
-set(CMAKE_CXX_STANDARD 14)
+# tell gcc/clang to use the c++17 standard
+set(CMAKE_CXX_STANDARD 17)
 
 if(CMAKE_SYSTEM_NAME STREQUAL "Android")
     set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wno-unused-function -Wno-unused-variable -O3 -funroll-loops -ftree-vectorize -ffast-math -fpermissive -fPIC ")

build_system/build_settings.py

@@ -16,7 +16,7 @@
 # J2V8 settings
 #-----------------------------------------------------------------------
 
-J2V8_VERSION_MAJOR, J2V8_VERSION_MINOR, J2V8_VERSION_PATCH = 6, 2, 1
+J2V8_VERSION_MAJOR, J2V8_VERSION_MINOR, J2V8_VERSION_PATCH = 6, 2, 2
 # J2V8_VERSION_SUFFIX = "-SNAPSHOT"
 J2V8_VERSION_SUFFIX = ""
 

docker/linux/Dockerfile

@@ -1,5 +1,5 @@
 # sys_image can be overridden from the CLI
-ARG sys_image=debian:stable
+ARG sys_image=debian:buster
 
 FROM $sys_image
 

jni/com_eclipsesource_v8_V8Impl.cpp

@@ -1868,7 +1868,7 @@ JNIEXPORT void JNICALL Java_com_eclipsesource_v8_V8__1setWeak
       jobject v8 = reinterpret_cast<V8Runtime*>(wrd->v8RuntimePtr)->v8;
       env->CallVoidMethod(v8, v8WeakReferenceReleased, wrd->objectHandle);
       delete(wrd);
-    }, WeakCallbackType::kFinalizer);
+    }, WeakCallbackType::kParameter);
 }
 
 JNIEXPORT void JNICALL Java_com_eclipsesource_v8_V8__1clearWeak

src/test/java/com/eclipsesource/v8/V8Test.java

@@ -74,7 +74,7 @@ public void testLowMemoryNotification() {
     public void testGetVersion_StartsWith9() {
         String v8version = V8.getV8Version();
 
-        assertTrue(v8version.startsWith("9."));
+        assertTrue(v8version.startsWith("10."));
     }
 
     @Test

v8/Dockerfile

@@ -1,4 +1,4 @@
-ARG sys_image=debian:10
+ARG sys_image=ubuntu:20.04
 
 FROM $sys_image
 
@@ -9,18 +9,24 @@ ARG target_cpu=x64
 
 # Update depedency of V8
 RUN apt-get -qq update && \
-  DEBIAN_FRONTEND=noninteractive apt-get -qq install -y \
-    lsb-release \
-    sudo \
-    apt-utils \
+    DEBIAN_FRONTEND=noninteractive apt-get install --upgrade -qq -y --no-install-recommends \
     git \
+    curl \
+    wget \
+    build-essential \
+    software-properties-common \
+    patchelf \
+    sudo \
+    zip \
+    unzip \
+    gcc gcc-multilib \
+    g++ g++-multilib \
+    execstack \
+    python3 \
     python \
-    lbzip2 \
-    curl  \
-    wget  \
-    xz-utils \
-    g++-8-arm-linux-gnueabihf \
-    gcc-arm-linux-gnueabihf
+    python3-pip \
+    python3-distutils \
+    python3-testresources
 
 RUN mkdir -p /v8build
 WORKDIR /v8build
@@ -33,21 +39,21 @@ RUN echo $PATH
 # Fetch V8 code
 RUN fetch v8
 WORKDIR /v8build/v8
-RUN git checkout 9.3.345.11
+RUN git checkout 10.3.174.14
+RUN sed -i 's/snapcraft/nosnapcraft/g' ./build/install-build-deps.sh
+RUN ./build/install-build-deps.sh
+RUN sed -i 's/nosnapcraft/snapcraft/g' ./build/install-build-deps.sh
 WORKDIR /v8build
 
 ENV target_os ${target_os}
 RUN echo "target_os= ['${target_os}']" >> .gclient
 RUN gclient sync
 
-WORKDIR /v8build/v8
-COPY install-deps.sh .
-RUN echo y | sh install-deps.sh
-
 ENV target_cpu ${target_cpu}
 ENV build_platform ${target_cpu}.release
 ENV path_to_args ${target_os}-${target_cpu}/args.gn
 
+WORKDIR /v8build/v8
 RUN ./tools/dev/v8gen.py ${build_platform} -vv
 
 RUN rm out.gn/${build_platform}/args.gn