Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bravyi-Kitaev #461

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bravyi-Kitaev #461

wants to merge 3 commits into from

Conversation

danclaudino
Copy link
Contributor

This PR:

  • Implements Bravyi-Kitaev ObservableTransform (resolves Implement Fermion-to-Spin Transforms #375)
  • Implements Hartree-Fock Circuit
  • Updates various classes to be able to use the BK transform (defaults to JW)
  • Fixes a minor bug in FermionOperator::normalize() and PauliOperator::normalize()
  • Removes (temporarily) some operator pools due to unphysical results in some cases

@danclaudino
WIP BK
cd06b8a 
Signed-off-by: Daniel Claudino <[email protected]>
@danclaudino
Implementation of Bravyi-Kitaev
74e298c 
Signed-off-by: Daniel Claudino <[email protected]>
@gitpod-io
Copy link

gitpod-io bot commented Jun 16, 2021

amccaskey
amccaskey reviewed Aug 6, 2021
View reviewed changes
quantum/observable/transforms/JordanWigner/JW.cpp
std::shared_ptr<Observable>
JW::transform(std::shared_ptr<Observable> Hptr_input) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you delete this preprocessing part - could be that the Observable is PySCF or something like that - it would have a fermionic structure, but will not pass the check that it is a FermionOperator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I did this because the algorithms in which we use the transforms have some pre-processing of sorts. More generally, I decided to put it back in case of a new application that doesn't rely on the already implemented algorithms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amccaskey amccaskey amccaskey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Fermion-to-Spin Transforms
2 participants
@danclaudino @amccaskey