Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix liveliness bug #802

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Fix liveliness bug #802

merged 1 commit into from
Mar 8, 2024

Conversation

OlivierHecart
Copy link
Contributor

This fixes a bug that could only be reproduced in rmw_zenoh and that was causing a dropped liveliness token to be wrongly relived: https://gist.github.com/Yadunund/63befdc4ef80eb10e2114b1bf2132708 .

@OlivierHecart OlivierHecart added the bug Something isn't working label Mar 7, 2024
@OlivierHecart OlivierHecart requested a review from Mallets March 7, 2024 15:23
@OlivierHecart OlivierHecart marked this pull request as ready for review March 7, 2024 15:23
@eclipse-zenoh-bot
Copy link
Contributor

@OlivierHecart If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

1 similar comment
@eclipse-zenoh-bot
Copy link
Contributor

@OlivierHecart If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@JEnoch JEnoch merged commit 2e79208 into main Mar 8, 2024
17 checks passed
@Mallets Mallets deleted the liveliness_fix branch March 8, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants