Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve locality default and optionality #321

Merged
merged 6 commits into from
Sep 15, 2022
Merged

Improve locality default and optionality #321

merged 6 commits into from
Sep 15, 2022

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Sep 14, 2022

No description provided.

@Mallets Mallets added the enhancement Existing things could work better label Sep 14, 2022
@OlivierHecart
Copy link
Contributor

OlivierHecart commented Sep 14, 2022

This forces to take an additional lock on the session on each call to declare_xxx, put, get before resolution of the builder.

@Mallets
Copy link
Member Author

Mallets commented Sep 14, 2022

Can you please point out which specific lines are your referring to?

@OlivierHecart
Copy link
Contributor

OlivierHecart commented Sep 14, 2022

Those lines :

origin: zread!(self.state).subscribers_origin,

origin: zread!(self.state).queryables_origin,

destination: zread!(self.state).publications_destination,

origin: zread!(self.state).subscribers_origin,

destination: zread!(self.state).queries_destination,

origin: zread!(self.state).subscribers_origin,

origin: zread!(self.state).queryables_origin,

@Mallets
Copy link
Member Author

Mallets commented Sep 14, 2022

Indeed, it would incur in an additional lock. That changes may be reverted then.

@Mallets Mallets merged commit fd47be0 into api-changes Sep 15, 2022
@Mallets Mallets deleted the locality branch September 15, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants