stabilize liveliness API #1646
stabilize liveliness API #1646
Conversation
|
PR missing one of the required labels: {'enhancement', 'bug', 'documentation', 'breaking-change', 'dependencies', 'internal', 'new feature'} |
milyin
changed the title
|
|
||
| - name: Run tests with SHM + unixpipe | ||
| if: ${{ matrix.os == 'ubuntu-latest' }} | ||
| run: cargo nextest run -F test -F shared-memory -F unstable -F transport_unixpipe -E 'not (test(test_default_features))' --exclude zenoh-examples --exclude zenoh-plugin-example --workspace | ||
| run: cargo nextest run -F test -F shared-memory -F unstable -F internal_config -F transport_unixpipe -E 'not (test(test_default_features))' --exclude zenoh-examples --exclude zenoh-plugin-example --workspace |
There was a problem hiding this comment.
Why there is the need of enabling internal_config?
There was a problem hiding this comment.
The liveliness test (and maybe others) uses direct access to config which is under this feature. I wanted to enable zenoh tests in stable mode so I had to detach internal_config from unstable
#1654
| @@ -34,7 +34,7 @@ default = [] | |||
| [dependencies] | |||
| tokio = { workspace = true, features = ["rt", "sync", "time", "macros", "io-std"] } | |||
| futures = { workspace = true } | |||
| zenoh = { workspace = true, features = ["unstable"], default-features = false } | |||
| zenoh = { workspace = true, features = ["unstable", "internal_config"], default-features = false } | |||
There was a problem hiding this comment.
Why there is the need of enabling internal_config?
There was a problem hiding this comment.
zenoh-ext uses direct access to config fields. Before it was hidden as the "unstable" included "internal_config"
Later I think we need to remove this feature #1655
|
@milyin is there an umbrella issue keeping track of API stabilization all repositories? |
Stablilization of liveliness API #1645