Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rustls, rustls-webpki and webpki-roots optional #1238

Merged

Conversation

fuzzypixelz
Copy link
Member

In f36b228 the zenoh-link-commons (used by zenoh-link) crate was made to depend on the aforementioned TLS crates. This is not necessary as the tls module is only used by zenoh-link-tls and zenoh-link-quic.

Copy link

@torsteingrindvik torsteingrindvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked cargo tree, looks good.
Also tried on our CI which had license issues before this PR, but now it's ok 🎉

@fuzzypixelz fuzzypixelz added the enhancement Existing things could work better label Jul 11, 2024
@fuzzypixelz fuzzypixelz self-assigned this Jul 11, 2024
@fuzzypixelz fuzzypixelz requested a review from JEnoch July 11, 2024 15:55
@Mallets Mallets merged commit 952cef8 into eclipse-zenoh:dev/1.0.0 Jul 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants