fix forgotten QoS and Timestamp ext processing for query/reply #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, I have tested it and it solves the issue. However there is still another issue which may not be related (and I guess we can open a different issue for it) in which the priority is automatically set to Data despite specifying different values, both while doing a query and when replying to it. |
DariusIMP
approved these changes
Jun 10, 2024
|
If the priority is automatically set to Data despite specifying different values then I wonder wether the proposed changes are enough. I think also at API level |
|
Fixed bug in QoS bitfield. It affected ALL our QoS Priority in all the messages. |
|
Tested it and it works fine now! 👍 |
Mallets
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1107