properties renamed to parameters, selector rework #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 10, 2024
4 tasks
Mallets
reviewed
Jun 12, 2024
milyin
commented
Jun 12, 2024
…o selector_rework3
…o selector_rework3
…o selector_rework3
…o selector_rework3
Mallets
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1070 and reduces importance of
Selectortype which is now just convenient wrapper for (KeyExpr, Parameters) pair without much usage throughout API. This also fixes the last item (time_range issue) in #1067zenoh_protocol::Parametersremoved, added bunch of standalone functions in modulezenoh_protocol::parametersinsteadzenoh_protocol::Propertiesrenamed tozenoh_protocol:Parameterszenoh_protocol:Parametersreexported fromzenohwithout wrapper typePredefinedParametersimplemented forParameterstype. This trait adds getters/setters and constant names for specific parameters used byzenoh