Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typos check to CI #1065

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Add typos check to CI #1065

merged 2 commits into from
Jun 10, 2024

Conversation

kilpkonn
Copy link
Contributor

Closes #1035

@wyfo
Copy link
Contributor

wyfo commented May 31, 2024

This check should also be added in .pre-commit-config.yaml. However, be careful when adding the hook, see crate-ci/typos#570. I'm against letting typos modifying files silently at commit, so default arguments should be overridden.

@Mallets Mallets requested a review from diogomatsubara May 31, 2024 07:25
@diogomatsubara diogomatsubara added the enhancement Existing things could work better label May 31, 2024
@kilpkonn
Copy link
Contributor Author

This check should also be added in .pre-commit-config.yaml. However, be careful when adding the hook, see crate-ci/typos#570. I'm against letting typos modifying files silently at commit, so default arguments should be overridden.

This repo doesn't have any pre-commit framework stuff tho. Do you think adding it just to run typos is worth it/are you planning to add it anyway?

@wyfo
Copy link
Contributor

wyfo commented May 31, 2024

This repo doesn't have any pre-commit framework stuff tho. Do you think adding it just to run typos is worth it/are you planning to add it anyway?

Sorry, I've added a pre-commit configuration in the branch dev/1.0.0, not in main. Don't bother adding it, I will do it when we will merge main in dev/1.0.0.

@kilpkonn kilpkonn requested a review from diogomatsubara June 6, 2024 05:59
diogomatsubara
diogomatsubara approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@diogomatsubara diogomatsubara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diogomatsubara diogomatsubara requested a review from Mallets June 10, 2024 08:16
@Mallets Mallets merged commit de78221 into eclipse-zenoh:main Jun 10, 2024
12 checks passed
Mallets added a commit that referenced this pull request Jun 19, 2024
@OlivierHecart @evshary
@fuzzypixelz @Mallets @kilpkonn @JLerxky @JEnoch
Merge/into/dev/1.0.0/from/main (#1169)
a612fd1 
* Add NOTE for LowLatency transport. (#1088)

Signed-off-by: ChenYing Kuo <[email protected]>

* fix: Improve debug messages in `zenoh-transport` (#1090)

* fix: Improve debug messages for failing RX/TX tasks

* fix: Improve debug message for `accept_link` timeout

* chore: Fix `clippy::redundant_pattern_matching` error

* Improve pipeline backoff (#1097)

* Yield task for backoff

* Improve comments and error handling in backoff

* Simplify pipeline pull

* Consider backoff configuration

* Add typos check to CI (#1065)

* Fix typos

* Add typos check to CI

* Start link tx_task before notifying router (#1098)

* Fix typos (#1110)

* bump quinn & rustls (#1086)

* bump quinn & rustls

* fix ci windows check

* add comments

* Fix interface name scanning when listening on IP unspecified for TCP/TLS/QUIC/WS (#1123)

Co-authored-by: Julien Enoch <[email protected]>

* Enable releasing from any branch (#1136)

* Fix cargo clippy (#1145)

* Release tables locks before propagating subscribers and queryables declarations to void dead locks (#1150)

* Send simple sub and qabl declarations using a given function

* Send simple sub and qabl declarations after releasing tables lock

* Send simple sub and qabl declarations after releasing tables lock (missing places)

* Update async-io

* Update base64 dependency

* Update event-listener dependency

* Update jsonschema dependency

* Update keyed-set dependency

* Update console-subscriber dependency

* Update pnet dependency

* Update rcgen dependency

* Update tokio-tungstenite dependency

* Update thread-priority dependency

* Fix typos

* Fix typos

* Add Unicode-3.0 to allowed licenses

---------

Signed-off-by: ChenYing Kuo <[email protected]>
Co-authored-by: ChenYing Kuo (CY) <[email protected]>
Co-authored-by: Mahmoud Mazouz <[email protected]>
Co-authored-by: Luca Cominardi <[email protected]>
Co-authored-by: Tavo Annus <[email protected]>
Co-authored-by: JLer <[email protected]>
Co-authored-by: Julien Enoch <[email protected]>
Mallets added a commit that referenced this pull request Jul 30, 2024
@Mallets @evshary
@fuzzypixelz @kilpkonn @JLerxky @JEnoch @OlivierHecart @YuanYuYuan @diogomatsubara @kydos
Merge/main into dev/1.0.0 (#1279)
502d3be 
* Add NOTE for LowLatency transport. (#1088)

Signed-off-by: ChenYing Kuo <[email protected]>

* fix: Improve debug messages in `zenoh-transport` (#1090)

* fix: Improve debug messages for failing RX/TX tasks

* fix: Improve debug message for `accept_link` timeout

* chore: Fix `clippy::redundant_pattern_matching` error

* Improve pipeline backoff (#1097)

* Yield task for backoff

* Improve comments and error handling in backoff

* Simplify pipeline pull

* Consider backoff configuration

* Add typos check to CI (#1065)

* Fix typos

* Add typos check to CI

* Start link tx_task before notifying router (#1098)

* Fix typos (#1110)

* bump quinn & rustls (#1086)

* bump quinn & rustls

* fix ci windows check

* add comments

* Fix interface name scanning when listening on IP unspecified for TCP/TLS/QUIC/WS (#1123)

Co-authored-by: Julien Enoch <[email protected]>

* Enable releasing from any branch (#1136)

* Fix cargo clippy (#1145)

* Release tables locks before propagating subscribers and queryables declarations to void dead locks (#1150)

* Send simple sub and qabl declarations using a given function

* Send simple sub and qabl declarations after releasing tables lock

* Send simple sub and qabl declarations after releasing tables lock (missing places)

* feat: make `TerminatableTask` terminate itself when dropped (#1151)

* Fix bug in keyexpr::includes leading to call get_unchecked on empty array UB (#1208)

* REST plugin uses unbounded flume channels for queries (#1213)

* fix: typo in selector.rs (#1228)

* fix: zenohd --cfg (#1263)

* fix: zenohd --cfg

* ci: trigger

* Update zenohd/src/main.rs

---------

Co-authored-by: Luca Cominardi <[email protected]>

* Fix failover brokering bug reacting to linkstate changes (#1272)

* Change missleading log

* Fix failover brokering bug reacting to linkstate changes

* Retrigger CI

---------

Co-authored-by: Luca Cominardi <[email protected]>

* Code format

* Fix clippy warnings

* Code format

* Fix Clippy errors from Rust 1.80 (#1273)

* Allow unexpected `doc_auto_cfg` flag

* Keep never-constructed logger interceptor

* Ignore interior mutability of `Resource`

* Fix typo

* Resolve `clippy::doc-lazy-continuation` errors

* Upgrade `[email protected]` to `[email protected]`

See time-rs/time#693

* Update Cargo.toml (#1277)

Updated description to be aligned with what we use everywhere else

* Merge ci.yaml

---------

Signed-off-by: ChenYing Kuo <[email protected]>
Co-authored-by: ChenYing Kuo (CY) <[email protected]>
Co-authored-by: Mahmoud Mazouz <[email protected]>
Co-authored-by: Tavo Annus <[email protected]>
Co-authored-by: JLer <[email protected]>
Co-authored-by: Julien Enoch <[email protected]>
Co-authored-by: OlivierHecart <[email protected]>
Co-authored-by: Yuyuan Yuan <[email protected]>
Co-authored-by: Diogo Matsubara <[email protected]>
Co-authored-by: OlivierHecart <[email protected]>
Co-authored-by: kydos <[email protected]>
Mallets added a commit that referenced this pull request Aug 27, 2024
@milyin @evshary
@fuzzypixelz @Mallets @kilpkonn @JLerxky @JEnoch @OlivierHecart @YuanYuYuan @diogomatsubara @kydos @brian049 @anhaabaete
Merge main into dev/1.0.0 (#1326)
6f43f95 
* Add NOTE for LowLatency transport. (#1088)

Signed-off-by: ChenYing Kuo <[email protected]>

* fix: Improve debug messages in `zenoh-transport` (#1090)

* fix: Improve debug messages for failing RX/TX tasks

* fix: Improve debug message for `accept_link` timeout

* chore: Fix `clippy::redundant_pattern_matching` error

* Improve pipeline backoff (#1097)

* Yield task for backoff

* Improve comments and error handling in backoff

* Simplify pipeline pull

* Consider backoff configuration

* Add typos check to CI (#1065)

* Fix typos

* Add typos check to CI

* Start link tx_task before notifying router (#1098)

* Fix typos (#1110)

* bump quinn & rustls (#1086)

* bump quinn & rustls

* fix ci windows check

* add comments

* Fix interface name scanning when listening on IP unspecified for TCP/TLS/QUIC/WS (#1123)

Co-authored-by: Julien Enoch <[email protected]>

* Enable releasing from any branch (#1136)

* Fix cargo clippy (#1145)

* Release tables locks before propagating subscribers and queryables declarations to void dead locks (#1150)

* Send simple sub and qabl declarations using a given function

* Send simple sub and qabl declarations after releasing tables lock

* Send simple sub and qabl declarations after releasing tables lock (missing places)

* feat: make `TerminatableTask` terminate itself when dropped (#1151)

* Fix bug in keyexpr::includes leading to call get_unchecked on empty array UB (#1208)

* REST plugin uses unbounded flume channels for queries (#1213)

* fix: typo in selector.rs (#1228)

* fix: zenohd --cfg (#1263)

* fix: zenohd --cfg

* ci: trigger

* Update zenohd/src/main.rs

---------

Co-authored-by: Luca Cominardi <[email protected]>

* Fix failover brokering bug reacting to linkstate changes (#1272)

* Change missleading log

* Fix failover brokering bug reacting to linkstate changes

* Retrigger CI

---------

Co-authored-by: Luca Cominardi <[email protected]>

* Code format

* Fix clippy warnings

* Code format

* Fix Clippy errors from Rust 1.80 (#1273)

* Allow unexpected `doc_auto_cfg` flag

* Keep never-constructed logger interceptor

* Ignore interior mutability of `Resource`

* Fix typo

* Resolve `clippy::doc-lazy-continuation` errors

* Upgrade `[email protected]` to `[email protected]`

See time-rs/time#693

* Update Cargo.toml (#1277)

Updated description to be aligned with what we use everywhere else

* fix: typos (#1297)

* Replace trees computation tasks with a worker (#1303)

* Replace trees computation tasks with a worker

* Address review comments

* Remove review comments

* zenohd-default config error #1292 (#1298)

* Zenohd panic when tring load file

When zenohd trying load file, if it have a problem it crash cause another treat was "unwrap", and it return to a type config. So, it crash and cause painic.

* zenohd default config error #1292

When tring load config file defined by -c option. With haver any problema "unwrap" has been to Config type.

I treat it return a Default Config whe it happen

* If file fail when try load configs

If file fail when try load configs

* Update main.rs

* Resolve typos at comment

Resolve typos at comment

* fix: typos (#1297)

* zenohd-default config error #1292 (#1298)

* Zenohd panic when tring load file

When zenohd trying load file, if it have a problem it crash cause another treat was "unwrap", and it return to a type config. So, it crash and cause painic.

* zenohd default config error #1292

When tring load config file defined by -c option. With haver any problema "unwrap" has been to Config type.

I treat it return a Default Config whe it happen

* If file fail when try load configs

If file fail when try load configs

* Update main.rs

* Resolve typos at comment

Resolve typos at comment

* Replace trees computation tasks with a worker (#1303)

* Replace trees computation tasks with a worker

* Address review comments

* Remove review comments

* revering fix #1298

---------

Signed-off-by: ChenYing Kuo <[email protected]>
Co-authored-by: ChenYing Kuo (CY) <[email protected]>
Co-authored-by: Mahmoud Mazouz <[email protected]>
Co-authored-by: Luca Cominardi <[email protected]>
Co-authored-by: Tavo Annus <[email protected]>
Co-authored-by: JLer <[email protected]>
Co-authored-by: Julien Enoch <[email protected]>
Co-authored-by: OlivierHecart <[email protected]>
Co-authored-by: Yuyuan Yuan <[email protected]>
Co-authored-by: Diogo Matsubara <[email protected]>
Co-authored-by: OlivierHecart <[email protected]>
Co-authored-by: kydos <[email protected]>
Co-authored-by: brianPA <[email protected]>
Co-authored-by: Tiago Neves <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

@diogomatsubara diogomatsubara diogomatsubara approved these changes

Assignees
No one assigned
Labels
enhancement Existing things could work better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add typos check to CI
4 participants
@kilpkonn @wyfo @diogomatsubara @Mallets