Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the missing unstable feature #1003

Conversation

YuanYuYuan
Copy link
Contributor

@YuanYuYuan YuanYuYuan commented May 2, 2024

Closes #963. The change of feature flags only affects the dev-dependencies and is safe for the downstream dependencies/bindings.

@YuanYuYuan
Copy link
Contributor Author

@Mallets can you please review this? Thanks.

@Mallets
Copy link
Member

Mallets commented May 2, 2024

Self-reference in [dev-dependencies] created some problems in the past for release.
@fuzzypixelz @OlivierHecart could you provide more insight on this?

@fuzzypixelz
Copy link
Member

fuzzypixelz commented May 28, 2024

Self-reference in [dev-dependencies] created some problems in the past for release. @fuzzypixelz @OlivierHecart could you provide more insight on this?

This has been extensively discussed in rust-lang/cargo#2911. @YuanYuYuan's workaround is standard procedure at this point. But it does introduce a cyclic dependency in the zenoh crate (to itself) which might break publishing: rust-lang/cargo#4242. Apparently Cargo checks if dev dependencies are published upon publishing. I'll have to test this.

@Mallets
Copy link
Member

Mallets commented Jun 13, 2024

I believe #1131 solved this issue and it can be hence closed. @YuanYuYuan ?

@YuanYuYuan
Copy link
Contributor Author

@Mallets, I've confirmed that the issue disappears after the fix. So let's close this PR.

@YuanYuYuan YuanYuYuan closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong feature flags in tests
3 participants