Add lru cache #841
Merged
Add lru cache #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'new feature', 'enhancement', 'dependencies', 'bug', 'internal', 'documentation', 'breaking-change'} |
sashacmc
reviewed
Dec 19, 2024
jean-roland
force-pushed
the
ft_lru_cache
branch
from
3544ba8 to
8a734d9
Compare
jean-roland
force-pushed
the
ft_lru_cache
branch
from
6e9b723 to
7f3926c
Compare
Co-authored-by: Alexander Bushnev <[email protected]>
jean-roland
force-pushed
the
ft_lru_cache
branch
from
7f3926c to
8ea1e65
Compare
sashacmc
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.1 introduced a placeholder rx cache feature that will be filled with this PR. Cache is still off by default because it's aimed at high throughput scenarios.
Cache itself is a double linked list (ideally suited for lru operations)
and has an optional binary tree hybridation to improve search time on bigger caches. Although given the memory requirements and embedded constraints it's off by default.associated to a sorted array for lookup.Changed some functions to accept keyexpr pointers instead of value.