Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve no_router test #829

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Improve no_router test #829

merged 1 commit into from
Dec 17, 2024

Conversation

sashacmc
Copy link
Member

@sashacmc sashacmc commented Dec 16, 2024 •
edited
Loading

  • Move common code to separate function
  • Add stderr check
  • Add liveliness
  • Fix error code check

@github-actions GitHub Actions
Copy link

PR missing one of the required labels: {'dependencies', 'breaking-change', 'documentation', 'enhancement', 'internal', 'new feature', 'bug'}

@sashacmc sashacmc added enhancement Things could work better internal Changes not included in the changelog labels Dec 16, 2024
@sashacmc
Improve no_router test
d2ada34 
- Move common code to separate function
- Add stderr check
- Add liveliness
- Fix error code check
@sashacmc sashacmc force-pushed the improve_no_router_test branch from 4884009 to d2ada34 Compare December 16, 2024 19:56
@sashacmc sashacmc marked this pull request as ready for review December 16, 2024 20:16
@sashacmc sashacmc requested a review from jean-roland December 16, 2024 20:16
@milyin milyin merged commit 9396627 into eclipse-zenoh:main Dec 17, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jean-roland jean-roland jean-roland approved these changes

Assignees
No one assigned
Labels
enhancement Things could work better internal Changes not included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sashacmc @jean-roland @milyin