Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy z_config_new #721

Merged
merged 1 commit into from
Oct 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/api.rst
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,6 @@ See details at :ref:`owned_types_concept`
Functions
^^^^^^^^^

.. autocfunction:: primitives.h::z_config_new
.. autocfunction:: primitives.h::z_config_default
.. autocfunction:: primitives.h::zp_config_get
.. autocfunction:: primitives.h::zp_config_insert
Expand Down
9 changes: 0 additions & 9 deletions include/zenoh-pico/api/primitives.h
Original file line number Diff line number Diff line change
Expand Up @@ -281,15 +281,6 @@ bool z_keyexpr_intersects(const z_loaned_keyexpr_t *l, const z_loaned_keyexpr_t
*/
bool z_keyexpr_equals(const z_loaned_keyexpr_t *l, const z_loaned_keyexpr_t *r);

/**
* Builds a new, zenoh-allocated, empty configuration.
* It consists in an empty set of properties for zenoh session configuration.
*
* Parameters:
* config: Pointer to uninitialized :c:type:`z_owned_config_t`.
*/
void z_config_new(z_owned_config_t *config);

/**
* Builds a new, zenoh-allocated, default configuration.
* It consists in a default set of properties for zenoh session configuration.
Expand Down
2 changes: 0 additions & 2 deletions src/api/api.c
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,6 @@ bool z_keyexpr_equals(const z_loaned_keyexpr_t *l, const z_loaned_keyexpr_t *r)
return _z_keyexpr_suffix_equals(l, r);
}

void z_config_new(z_owned_config_t *config) { config->_val = _z_config_empty(); }

z_result_t z_config_default(z_owned_config_t *config) { return _z_config_default(&config->_val); }

const char *zp_config_get(const z_loaned_config_t *config, uint8_t key) { return _z_config_get(config, key); }
Expand Down
3 changes: 0 additions & 3 deletions tests/z_api_alignment_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,6 @@ int main(int argc, char **argv) {

printf("Testing Configs...");
z_owned_config_t _ret_config;
z_config_new(&_ret_config);
assert(!z_internal_check(_ret_config)); // null config corresponds to empty one
z_drop(z_move(_ret_config));
z_config_default(&_ret_config);
assert(z_internal_check(_ret_config));
#ifdef ZENOH_PICO
Expand Down
Loading