Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods for z_owned_strings_array_t creation: #674

Merged

Conversation

sashacmc
Copy link
Member

@sashacmc sashacmc commented Sep 16, 2024

  • z_string_array_new
  • z_string_array_push_by_alias
  • z_string_array_push_by_copy

Closes: #670

Copy link

PR missing one of the required labels: {'dependencies', 'breaking-change', 'documentation', 'internal', 'bug', 'enhancement', 'new feature'}

@sashacmc sashacmc added enhancement Things could work better api sync Synchronize API with other bindings labels Sep 16, 2024
@sashacmc sashacmc force-pushed the add_string_array_ctr branch from 5c8c48f to 70c3205 Compare September 16, 2024 18:17
@sashacmc sashacmc marked this pull request as ready for review September 16, 2024 18:17
z_string_array_new
z_string_array_push_by_alias
z_string_array_push_by_copy
@DenisBiryukov91
Copy link
Contributor

Please update the docs

@sashacmc
Copy link
Member Author

Please update the docs

Unfortunately, none of the z_strings_array_t methods are in the documentation yet. That's why it should be in another PR (it would be good to do a full review and update of the documentation)

@yellowhatter yellowhatter merged commit 3a2280c into eclipse-zenoh:main Sep 17, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api sync Synchronize API with other bindings enhancement Things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add misses z_string_array methods
4 participants