Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config clone function #606

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

jean-roland
Copy link
Contributor

Closes #600

@milyin milyin merged commit 68d5769 into eclipse-zenoh:dev/1.0.0 Aug 28, 2024
52 checks passed
@bjsowa
Copy link
Contributor

bjsowa commented Aug 28, 2024

@jean-roland Would it be possible to add error checking to z_config_clone and return the int8_t result ?
Also, why is config still using _Z_OWNED_FUNCTIONS_NO_COPY_DEF and _Z_OWNED_FUNCTIONS_VALUE_NO_COPY_IMPL macros, instead of _Z_OWNED_FUNCTIONS_DEF and _Z_OWNED_FUNCTIONS_VALUE_IMPL

@jean-roland jean-roland deleted the ft_config_clone branch August 28, 2024 12:50
@jean-roland
Copy link
Contributor Author

@bjsowa for the signature change you'll have to request it to Zenoh-C as pico is bound to follow the common C API.

I implemented a clone function and not a copy one, but I could. Anyway, I forgot to add z_config_clone to the z_clone macro so I'll have to open a new PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants