Add weak references #510
Merged
Add weak references #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-roland
force-pushed
the
ft_query_reply
branch
4 times, most recently
from
4e11588 to
4cd4404
Compare
jean-roland
force-pushed
the
ft_query_reply
branch
from
2201142 to
0f5b08d
Compare
jean-roland
force-pushed
the
ft_query_reply
branch
from
a4bf07b to
edd9047
Compare
DenisBiryukov91
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #476, I realised the session reference itself was dropped by the refcount which means the query has no way of knowing if the session is still valid.
A possible solution is to introduce weak references. The query having a session weak references, it would be able to check the session validity before the whole rc container is dropped.
Bonus: Working on this, I realized the
z_clonewas not working properly and there was a consolidation mode edge case when receiving replies.