Subscriber callbacks now receive a refcounted z_sample #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashacmc
suggested changes
May 15, 2024
| } | ||
|
|
||
| void _z_sample_move(_z_sample_t *dst, _z_sample_t *src) { | ||
| dst->keyexpr._id = src->keyexpr._id; // FIXME: call the z_keyexpr_move |
There was a problem hiding this comment.
Maybe we should finally fix this FIXME?
There was a problem hiding this comment.
The function doesn't exist, I wasn't sure if it was the right PR to create those. Because I might as well do it for all of them.
| @@ -45,7 +45,7 @@ void reply_dropper(void *ctx) { | |||
| void reply_handler(z_owned_reply_t *oreply, void *ctx) { | |||
| (void)(ctx); | |||
| if (z_reply_is_ok(oreply)) { | |||
| z_sample_t sample = z_reply_ok(oreply); | |||
| z_loaned_sample_t sample = z_reply_ok(oreply); | |||
There was a problem hiding this comment.
Please revert z_reply_ok result type renaming z_sample_t / z_loaned_sample_t
(z_reply_ok in the new API will return const z_loaned_sample_t *, I already did it and this renaming will only introduce additional conflicts.)
sashacmc
approved these changes
May 15, 2024
OlivierHecart
merged commit 382e3ab
into
eclipse-zenoh:protocol_changes
51 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #327, this PR switch to refcounted z_sample for subscriber callbacks so they can be easily used out of the callback's context. Now it necessarily impacts the API a little, but this will be changed in a future PR anyway so considerations on this aspect should be limited.
This PR contains:
If you could review this @sashacmc.