Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store declare information on te receiver side #378

Merged

Conversation

jean-roland
Copy link
Contributor

@jean-roland jean-roland commented Mar 21, 2024

With interest feature on, the receiver will store data from declares in order to retrieve the context simply from the undeclare id as they no longer contain key expressions.

Related to #331

@eclipse-zenoh-bot
Copy link

@jean-roland If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

return _Z_RES_OK;
}

int8_t _z_interest_process_undeclares(_z_session_t *zn, const _z_declaration_t *decl) {

Check warning

Code scanning / Cppcheck (reported by Codacy)

misra violation 804 with no text in the supplied rule-texts-file Warning

misra violation 804 with no text in the supplied rule-texts-file
@@ -29,6 +29,12 @@
#include "zenoh-pico/utils/logging.h"

#if Z_FEATURE_INTEREST == 1
void _z_declare_data_clear(_z_declare_data_t *data) { _z_keyexpr_clear(&data->_key); }

_Bool _z_declare_data_eq(const _z_declare_data_t *left, const _z_declare_data_t *right) {

Check warning

Code scanning / Cppcheck (reported by Codacy)

misra violation 804 with no text in the supplied rule-texts-file Warning

misra violation 804 with no text in the supplied rule-texts-file
@@ -29,6 +29,12 @@
#include "zenoh-pico/utils/logging.h"

#if Z_FEATURE_INTEREST == 1
void _z_declare_data_clear(_z_declare_data_t *data) { _z_keyexpr_clear(&data->_key); }

Check warning

Code scanning / Cppcheck (reported by Codacy)

misra violation 804 with no text in the supplied rule-texts-file Warning

misra violation 804 with no text in the supplied rule-texts-file
@@ -322,6 +408,8 @@
}

#else
void _z_flush_interest(_z_session_t *zn) { _ZP_UNUSED(zn); }

Check warning

Code scanning / Cppcheck (reported by Codacy)

misra violation 804 with no text in the supplied rule-texts-file Warning

misra violation 804 with no text in the supplied rule-texts-file
@eclipse-zenoh-bot
Copy link

@jean-roland If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@OlivierHecart OlivierHecart merged commit b0ae036 into eclipse-zenoh:protocol_changes Mar 22, 2024
32 of 51 checks passed
@jean-roland jean-roland deleted the ft_declare_data branch April 9, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants