Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change declare interest to new packet format #367

Merged

Conversation

jean-roland
Copy link
Contributor

@jean-roland jean-roland commented Mar 6, 2024

Align declare interest packet format with Zenoh.

Related to #331

Some piggybacking in this PR:

  • Remove keyexpr from undeclare messages in Unicast
  • Refactor session mutex locking to go through a dedicated function

@eclipse-zenoh-bot
Copy link

@jean-roland If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

src/session/interest.c Fixed Show fixed Hide fixed
src/session/interest.c Fixed Show fixed Hide fixed
src/session/interest.c Fixed Show fixed Hide fixed
src/session/interest.c Fixed Show fixed Hide fixed
src/session/interest.c Fixed Show fixed Hide fixed
@eclipse-zenoh-bot
Copy link

@jean-roland If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@eclipse-zenoh-bot
Copy link

@jean-roland If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@OlivierHecart OlivierHecart self-requested a review March 13, 2024 08:55
@OlivierHecart OlivierHecart merged commit 7fbce2f into eclipse-zenoh:protocol_changes Mar 18, 2024
30 of 50 checks passed
@jean-roland jean-roland deleted the ft_interest_encode branch April 9, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants