Fix/remove qos designated initializers #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milyin
approved these changes
Feb 25, 2024
| _Bool nodrop = congestion_control == Z_CONGESTION_CONTROL_DROP ? 0 : 1; | ||
| _z_n_qos_t ret = {._val = (uint8_t)((express << 4) | (nodrop << 3) | priority)}; | ||
| ret._val = (uint8_t)((express << 4) | (nodrop << 3) | priority); |
There was a problem hiding this comment.
I'd prefer the form
_z_n_qos_t ret = { uint8_t)((express << 4) | (nodrop << 3) | priority };
This would guarantee that all fields in _z_n_qos_t are set.
Though this variant works too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move qos-related functions from header into .c to hide usage of designated initializers from c++ (closes #352)