Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement verbatim chunks for key expressions #325

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Implement verbatim chunks for key expressions #325

merged 4 commits into from
Jan 23, 2024

Conversation

p-avital
Copy link
Contributor

@p-avital p-avital commented Jan 22, 2024 •
edited
Loading

  • Implement intersection
  • Implement inclusion
  • Equality and disjunction don't need changes.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 22, 2024
View reviewed changes
src/utils/string.c
@@ -106,6 +107,10 @@
}
return result;
}
_z_str_se_t _z_splitstr_split_once(_z_splitstr_t src, _z_str_se_t *next) {

Check warning

Code scanning / Cppcheck (reported by Codacy)

misra violation 804 with no text in the supplied rule-texts-file Warning

misra violation 804 with no text in the supplied rule-texts-file
src/utils/string.c
@@ -91,6 +91,7 @@
return result;
}

_Bool _z_splitstr_is_empty(const _z_splitstr_t *src) { return src->s.start == NULL; }

Check warning

Code scanning / Cppcheck (reported by Codacy)

misra violation 804 with no text in the supplied rule-texts-file Warning

misra violation 804 with no text in the supplied rule-texts-file
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 22, 2024
View reviewed changes
src/protocol/keyexpr.c Fixed Show fixed Hide fixed
@jean-roland
Copy link
Contributor

LGTM

@Mallets Mallets merged commit b52ea11 into main Jan 23, 2024
94 checks passed
@Mallets Mallets deleted the keyexpr-namespaces branch January 23, 2024 15:25
@gabrik gabrik added the new feature Something new is needed label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees
No one assigned
Labels
new feature Something new is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@p-avital @jean-roland @Mallets @gabrik