-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix c99 compilation #317
Merged
Mallets
merged 4 commits into
eclipse-zenoh:master
from
jean-roland:fix_c99_compilation
Jan 12, 2024
Merged
Fix c99 compilation #317
Mallets
merged 4 commits into
eclipse-zenoh:master
from
jean-roland:fix_c99_compilation
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mallets
approved these changes
Jan 12, 2024
cguimaraes
reviewed
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
p-avital
pushed a commit
that referenced
this pull request
Jan 17, 2024
* fix: build tests only in c11 * fix: remove c11 macros from examples * feat: add a way to force c99 standard * ci: add a c99 compilation test
Mallets
pushed a commit
that referenced
this pull request
Jan 18, 2024
* attachment API implemented, todo: integration with options and codecs * Fix c99 compilation (#317) * fix: build tests only in c11 * fix: remove c11 macros from examples * feat: add a way to force c99 standard * ci: add a c99 compilation test * Attachments validated on pub/sub * fix uses of this which breaks C++ compilation * remove inlines that should not have been there * move this fixes * fix merge goofs * disable query/reply attachments for to release pub/sub attachments * fix initialization in _z_msg_make_query * increase timeout for single thread action * remove accidental internal header inclusions * getting desperate for single-thread CI to link this * fix default constructor for put options * fix default options * remove accidentatlly included valgrind core file * back to 5 min timeout for ST test * make attachments optional * oops * z_bytes: expose wrap and rename new to from_str --------- Co-authored-by: Jean-Roland Gosse <[email protected]>
p-avital
pushed a commit
that referenced
this pull request
Jan 18, 2024
* Fix c99 compilation (#317) * fix: build tests only in c11 * fix: remove c11 macros from examples * feat: add a way to force c99 standard * ci: add a c99 compilation test * fix: set correct session pointer type * refactor: rename sptr to rc * feat: add compiler based definition * fix: allocate int instead of int pointer * fix: align implementation counter size * fix: require single thread config to use single thread implem * feat: add c99 gcc rc implementation * refactor: rename derived sptr types to rc * feat: name anon struct for forward declaration * feat: add _z_session refcounter type * chore: clang-format * chore: update gitignore * build: add compiler id log * build: add compiler symbol on platformio builds * feat: remove superfluous function * feat: go through indirect session pointer * fix: use correct type type for session pointers * feat: use session ref counter in z_session * fix: prevent segfault when clearing empty session * fix: drop owned config all the time * feat: add new_from_val rc function * feat: switch publisher sesssion ptr to rc * feat: switch subscriber session ptr to rc * fix: remove unnecessary dependency * fix: add necessary dependency * feat: switch queryable session ptr to rc * refactor: flatten queryable primitives * refactor: flatten subscriber primitives * refactor: flatten publisher primitives * feat: change rc to use a single inner pointer * feat: mutualize rc code between implems * chore: clang-format * fix: compilation issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C99 compilation was broken because of the usage of c11 generics macros: