fix: double free when using decode into slice

include/zenoh-pico/collections/slice.h

@@ -39,13 +39,11 @@ int8_t _z_slice_init(_z_slice_t *bs, size_t capacity);
 _z_slice_t _z_slice_make(size_t capacity);
 _z_slice_t _z_slice_wrap(const uint8_t *bs, size_t len);
 _z_slice_t _z_slice_steal(_z_slice_t *b);
-
 void _z_slice_copy(_z_slice_t *dst, const _z_slice_t *src);
 _z_slice_t _z_slice_duplicate(const _z_slice_t *src);
 void _z_slice_move(_z_slice_t *dst, _z_slice_t *src);
 void _z_slice_reset(_z_slice_t *bs);
 _Bool _z_slice_is_empty(const _z_slice_t *bs);
-
 _Bool _z_slice_eq(const _z_slice_t *left, const _z_slice_t *right);
 void _z_slice_clear(_z_slice_t *bs);
 void _z_slice_free(_z_slice_t **bs);
@@ -75,6 +73,7 @@ uint32_t _z_bytes_to_uint32(const _z_bytes_t *bs);
 uint64_t _z_bytes_to_uint64(const _z_bytes_t *bs);
 float _z_bytes_to_float(const _z_bytes_t *bs);
 double _z_bytes_to_double(const _z_bytes_t *bs);
+_z_slice_t _z_bytes_to_slice(const _z_bytes_t *bytes);
 _z_bytes_t _z_bytes_from_uint8(uint8_t val);
 _z_bytes_t _z_bytes_from_uint16(uint16_t val);
 _z_bytes_t _z_bytes_from_uint32(uint32_t val);

src/api/api.c

@@ -325,7 +325,7 @@ int8_t z_bytes_decode_into_slice(const z_loaned_bytes_t *bytes, z_owned_slice_t
         return _Z_ERR_SYSTEM_OUT_OF_MEMORY;
     }
     // Convert bytes to slice
-    *dst->_val = bytes->_slice;
+    *dst->_val = _z_bytes_to_slice(bytes);
     return _Z_RES_OK;
 }
 

src/collections/slice.c

@@ -100,6 +100,7 @@ _z_slice_t _z_slice_duplicate(const _z_slice_t *src) {
 }
 
 _Bool _z_slice_is_empty(const _z_slice_t *bs) { return bs->len == 0; }
+
 _z_slice_t _z_slice_steal(_z_slice_t *b) {
     _z_slice_t ret = *b;
     *b = _z_slice_empty();
@@ -191,6 +192,17 @@ double _z_bytes_to_double(const _z_bytes_t *bs) {
     return val;
 }
 
+_z_slice_t _z_bytes_to_slice(const _z_bytes_t *bytes) {
+    // Allocate slice
+    _z_slice_t ret = _z_slice_make(bytes->_slice.len);
+    if (!_z_slice_check(ret)) {
+        return ret;
+    }
+    // Recopy data
+    memcpy((uint8_t *)ret.start, bytes->_slice.start, bytes->_slice.len);
+    return ret;
+}
+
 _z_bytes_t _z_bytes_from_uint8(uint8_t val) {
     _z_bytes_t ret = _z_bytes_null();
     // Init bytes array