Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package generation #793

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

DenisBiryukov91
Copy link
Contributor

@DenisBiryukov91 DenisBiryukov91 commented Oct 28, 2024

move static lib to dev package;
remove unnecessarily set values, they can be passed as flags during cmake .. invocation, i.e.

cmake -DCPACK_DEBIAN_PACKAGE_ARCHITECTURE=...  #(defaults to host one,  btw this is darwin_arm64 for mac, and not just arm64) \
 -DCPACK_RPM_PACKAGE_ARCHITECTURE=... #(defaults to the  host one) \
 -DCPACK_PACKAGE_NAME=... #(defaults to zenohc) \
..

move static lib to dev package;
@DenisBiryukov91 DenisBiryukov91 added the internal Changes not included in the changelog label Oct 28, 2024
@DenisBiryukov91 DenisBiryukov91 changed the title move static lib to dev package fix package generation Oct 29, 2024
@diogomatsubara
Copy link
Contributor

I tested this PR changes here: https://github.com/eclipse-zenoh/zenoh-c/actions/runs/11596394063/attempts/1 and they work well with PR #781

@Mallets Mallets merged commit 4765634 into eclipse-zenoh:main Oct 31, 2024
19 checks passed
@DenisBiryukov91 DenisBiryukov91 deleted the fix-pacakge branch December 16, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants