make z_drop on zenoh entities call actual drop instead of undeclare #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: breaking-change bug dependencies documentation enhancement new feature internal |
|
PR missing one of the required labels: breaking-change bug dependencies documentation enhancement new feature internal |
sashacmc
reviewed
Sep 3, 2024
| #[allow(clippy::missing_safety_doc)] | ||
| #[no_mangle] | ||
| pub extern "C" fn z_queryable_drop(this_: &mut z_moved_queryable_t) { | ||
| z_undeclare_queryable(this_); | ||
| std::mem::drop(this_.take_rust_type()) |
There was a problem hiding this comment.
Should it be undeclared before the drop then?
There was a problem hiding this comment.
No. The drop automatically undeclares currently. With eclipse-zenoh/zenoh#1334 drop and undeclare will intentionally have different behavior.
milyin
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make z_drop on zenoh entities call actual drop instead of undeclare.
This is in particular will be required to support eclipse-zenoh/zenoh#1334.