Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use same name for debug and release packages #629

Conversation

DenisBiryukov91
Copy link
Contributor

use same name for debug and release packages

@milyin
Copy link
Contributor

milyin commented Aug 29, 2024

Different package names were made purposedly to allow to install both debug and release versions in parallel. Before this update there was special check which protected user from accidentally installing debug variant of the library and get awful performance due to this.
But this approach existed in assumption that installation is always performed into user's operating system (/usr/lib, etc)
As we see now, that actually installation is just some operation which can be wrapped by another cmake script, I'm ok to make update which maximally satisfies the assumption made by this script, this is more important now.
Precisely, this update helps to fix problem with compatibility with amend_cmake library used by ros2: eclipse-zenoh/zenoh-cpp#188

@milyin milyin merged commit cde7501 into eclipse-zenoh:dev/1.0.0 Aug 29, 2024
16 checks passed
@DenisBiryukov91 DenisBiryukov91 deleted the dev/same_name_for_debug_and_release_packages branch December 16, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants