Add source info support #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashacmc
force-pushed
the
source_info_support
branch
from
d66ad74 to
1a41a84
Compare
milyin
requested changes
Jun 6, 2024
tests/z_int_pub_sub_test.c
Outdated
| exit(-1); | ||
| } | ||
| const uint64_t sn = z_source_info_sn(source_info); | ||
| if (sn != 24) { |
There was a problem hiding this comment.
Is it possible somehow to avoid usage of magic numbers?
milyin
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
z_owned_source_info_tandz_loaned_source_info_ttypes for representSourceInfoAdded
z_entity_global_id_ttype for representEntityGlobalIdAdded source_info fields to:
z_get_options_tz_publisher_put_options_tz_put_options_tz_query_reply_options_tAdded
z_sample_source_infogetterAdded test, updated Cargo.lock to use updated zenoh (with fix to be aligned to new zenoh)
Closes: #383