Adopted shm api #405
Merged
Adopted shm api #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: include/zenoh_commons.h include/zenoh_macros.h
- support POSIX SHM provider
Conflicts: include/zenoh_commons.h include/zenoh_macros.h
- C Provider and Client API tests
Conflicts: include/zenoh_commons.h include/zenoh_macros.h
Conflicts: Cargo.toml.in
- shm to payload API integration - examples - some improvements
Conflicts: src/payload.rs src/session.rs
- small fixes in tests
Conflicts: include/zenoh_commons.h src/payload.rs
|
|
||
| /// Mutably borrows ZShm slice | ||
| #[no_mangle] | ||
| pub extern "C" fn z_shm_loan_mut(this: &mut z_owned_shm_t) -> &mut z_loaned_shm_t { |
There was a problem hiding this comment.
What is the difference between these 2 methods? can we have just one loan_mut, that is allowed to return null ?
There was a problem hiding this comment.
I didn't catch your question, sorry
There was a problem hiding this comment.
Sorry, I did not see the difference in return value. The question should likely be what is the difference between &mut z_loan_shm_mut_t and &mut z_loaned_shm_mut_t, I believe the user would expect that the first one would allow to modify zsh slice as well
There was a problem hiding this comment.
Right. The C API follows this schema from Rust API:
Conflicts: include/zenoh_commons.h
Conflicts: docs/examples.rst include/zenoh_commons.h src/get.rs
- CI without shared-memory feature by default
|
@DenisBiryukov91 @milyin I think we can merge |
- move shm types to zenoh_opaque.h
|
Looks good for me. |
Conflicts: build-resources/opaque-types/src/lib.rs splitguide.yaml
milyin
approved these changes
Jun 6, 2024
Conflicts: Cargo.lock build-resources/opaque-types/Cargo.lock build-resources/opaque-types/Cargo.toml build-resources/opaque-types/src/lib.rs src/get.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.