Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS loading fix #25

Merged
merged 3 commits into from
Nov 28, 2023
Merged

TLS loading fix #25

merged 3 commits into from
Nov 28, 2023

Conversation

DariusIMP
Copy link
Member

  • Loading WebPKI certificates by default
  • Fix crash when specifying an empty tls certificate
  • TLS sensitive data now is loaded as private (i.e. the code expects the user to have specified the certificates wrapped around a 'private' key).
  • Letting the user to inline the TLS certificate as base64.
  • The field root_ca_certificate is now named root_ca_certificate_file to distinguish it from the new root_ca_certificate_base64 file.
  • Updated the README and the example configuration.

TESTED: Manually tested with MinIO and AWS.

@DariusIMP
Fix TLS certs loading.
868cb7e 
If the root_ca_certificate field was an empty string, then an error was thrown.
This commit fixes the issue and also implements the functionalities already existing on Zenoh
to load an embedded certificate.
@DariusIMP
Fix certs loading bug
7aea153
@DariusIMP
Modifying log
c64be70
@gabrik
Copy link
Contributor

gabrik commented Nov 17, 2023

Tested with a configuration from the PaaS it solves the issue.

@gabrik gabrik requested a review from Mallets November 27, 2023 16:40
@gabrik gabrik merged commit 477a0b5 into eclipse-zenoh:main Nov 28, 2023
3 checks passed
@DariusIMP DariusIMP deleted the tls_fix branch November 28, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Awaiting requested review from Mallets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DariusIMP @gabrik