-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1247 - Maven build use node from PATH on mac os #1342
Conversation
4bbd4a0
to
d0cebb1
Compare
@zulus I don't get how does it help to use embedded Node.js instead of a version that is found and used when
|
Because rather than just run: Based on executable location search for
|
Just check console log for tests (MacOS, Windows, Linux) |
Won't this
I had Node.js 20 configured for this purpose on MacOS GitHub build action :) |
No, `#!' is run structure for unix "*sh" only, for node (any js interpreter) is just a comment, in same way works "runnable" PHP/python/ruby scripts. On windows npm.cmd, doing nearly same as my path, search for node.exe, cmd.js and later just run command "node jsfile other params" |
So, |
After this path no both will be directly from embedder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Introduce NodeJSManager helpers to always produce ProcessBuilder with commands:
node_executable npm_location rest commands
these command is also used in NpmLaunchDelegate!