Update CSS language configuration and grammars to the latest ones fro… #1246
Conversation
vrubezhny
force-pushed
the
update-css-grammars-1.79.0
branch
from
fedaa97
to
b021426
Compare
vrubezhny
force-pushed
the
update-css-grammars-1.79.0
branch
2 times, most recently
from
ecbe2cd
to
6f68cc5
Compare
|
@vrubezhny what is missing here? |
vrubezhny
force-pushed
the
update-css-grammars-1.79.0
branch
2 times, most recently
from
39d8fa1
to
3178899
Compare
The idea to start using o.e.tm4e.language_pack instead of copying the vscode grammars to wwd which initially was delayed due to the problems with XML grammars IIRC and some problems while trying to switch to using some other grammars from TM4E language pack. I've updated the PR with the CSS related grammars to the latest ones from VSCode 1.84.0, where the last changes were made on the CSS related grammars and which was approved by IP Team in -/-/vscode/language-features-subset/1.84.0 So, we can either merge the PR #1429 by @sebthom (which is a minimal and safe change) or merge this PR which still requires some more testing due to its bigger size, but brings the full set of latest VSCode CSS grammars and language Configurations. All the JUnit tests passed successfully including the updated JUnit Test , but still this PR worth a better testing. |
OK, it would be good if we can manage to tackle that directly. @sebthom what do you think about trying it instead? Just make wildwebdeveloper require TM4E language pack bundle and 🤞. |
|
I think that would actually make sense. you need to check however if you are using grammars not included in the language pack (e. g. vuejs?) and continue maintaining them in wwd. |
vrubezhny
force-pushed
the
update-css-grammars-1.79.0
branch
from
3178899
to
98d0a33
Compare
|
@vrubezhny you could also update to vscode 1.85.0 see https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/11873 |
I cannot see any relevant changes regarding the Language Servers since 1.85 (we are updated to) nor regarding the TM4E Language Grammars/Configurations we use since 1.84 (the CSS Grammars used in this PR). Do you mean any certain change we've missed? |
no, I haven't done a diff between 1.84 and 1.85 regarding the CSS syntax. this was just an info that we have approval to use the syntaxes from 1.85 |
|
Now with the 0.9.0 release of tm4e and the updated language pack you could also do what @mickaelistria suggested and remove the syntax altogether and depend on the tm4e language pack. |
mickaelistria
force-pushed
the
update-css-grammars-1.79.0
branch
from
98d0a33
to
5f93f9a
Compare
|
/request-license-review |
✔️ All licenses already successfully vetted. Workflow run (with attached summary files): |
|
No longer needed as tm4e provides this for us now 796ae27 |
…m VSCode 1.84.0