Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not include JustJ JREs in your update site #938

Closed
merks opened this issue Nov 2, 2022 · 5 comments
Closed

Please do not include JustJ JREs in your update site #938

merks opened this issue Nov 2, 2022 · 5 comments

Comments

@merks
Copy link
Contributor

merks commented Nov 2, 2022

Please do not include JustJ JREs in your update site:

https://download.eclipse.org/wildwebdeveloper/snapshots/plugins/

People with that site available will generally end up updating to whatever JRE you are providing there:

[2022-09-14 10:10:58] Downloading org.eclipse.justj.openjdk.hotspot.jre.full.win32.x86_64
[2022-09-14 10:10:58] Fetching org.eclipse.justj.openjdk.hotspot.jre.full_18.0.1.v20220515-1614.jar from https://download.eclipse.org/wildwebdeveloper/releases/0.15.0/features/ (21.46kB)
[2022-09-14 10:10:58] Fetching org.eclipse.justj.openjdk.hotspot.jre.full_18.0.1.v20220515-1614.jar from https://download.eclipse.org/wildwebdeveloper/releases/0.15.0/plugins/ (19.84kB)
[2022-09-14 10:10:58] Fetching org.eclipse.justj.openjdk.hotspot.jre.full.win32.x86_64_18.0.1.v20220515-1614.jar from https://download.eclipse.org/wildwebdeveloper/releases/0.15.0/plugins/ (112.34MB)
[2022-09-14 10:10:59] Fetching org.eclipse.justj.openjdk.hotspot.jre.full.win32.x86_64_18.0.1.v20220515-1614.jar from https://download.eclipse.org/wildwebdeveloper/releases/0.15.0/plugins/
[2022-11-02 14:15:53] Fetching org.eclipse.justj.openjdk.hotspot.jre.full_19.0.0.v20221005-1658.jar from https://download.eclipse.org/wildwebdeveloper/snapshots/plugins/ (19,81kB)
[2022-11-02 14:15:53] Fetching org.eclipse.wildwebdeveloper.xml_1.0.0.202210262109.jar from https://download.eclipse.org/wildwebdeveloper/snapshots/plugins/ (8,48MB)
[2022-11-02 14:15:53] Fetching org.eclipse.justj.openjdk.hotspot.jre.full_19.0.0.v20221005-1658.jar from https://download.eclipse.org/wildwebdeveloper/snapshots/features/ (23,28kB)
[2022-11-02 14:15:53] Fetching org.eclipse.justj.openjdk.hotspot.jre.full.win32.x86_64_19.0.0.v20221005-1658.jar from https://download.eclipse.org/wildwebdeveloper/snapshots/plugins/ (116,67MB)
[2022-11-02 14:15:54] Fetching org.eclipse.wildwebdeveloper.xml_1.0.0.202210262109.jar from https://download.eclipse.org/wildwebdeveloper/snapshots/plugins/
[2022-11-02 14:15:54] Fetching org.eclipse.justj.openjdk.hotspot.jre.full.win32.x86_64_19.0.0.v20221005-1658.jar from https://download.eclipse.org/wildwebdeveloper/snapshots/plugins/
@mickaelistria
Copy link
Contributor

Unfortunately, this is not easy: JustJ is included in the RCP product and every transitive dependency is included in a p2 repo when it's built from an RCP product.

@merks
Copy link
Contributor Author

merks commented Nov 2, 2022

I see yes. Better would be to keep the product site separate from the site for the reusable features (as is done by the Aggregator and by Oomph's installer)...

Is there a touchpoint adding the update site to IDEs? I don't think there is... But I'm not sure how this site ended up in my Eclipse SDK installation's available sites preferences...

@vrubezhny
Copy link
Contributor

Now should be fixed with #1238

@sratz
Copy link

sratz commented Oct 20, 2023

It's not really fixed.

#1238 removed the justj artifacts from the actual repo, however, simply the fact that the category.xml contains a <repository-reference> to JustJ still causes unwanted updates to justj itself.

  1. Before
    image

  2. Check for updates
    image

  3. Press Cancel (!) and check update sites again:
    image

This is all very unusual:

  • WildWebDevelopers decides to filter our JustJ in the category.xml to control what to bundle
  • Yet, for some reason this causes P2 to add a repository in the list of available update sites and initiates updates that are not desired. Is this really intended?

@sratz
Copy link

sratz commented Oct 30, 2023

I have opened a follow-up ticket #1380 for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants